Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665494
| From | Cao jin <caoj.fnst@cn.fujitsu.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] Kbuild: tiny correction on `make help` |
| Date | 2017-06-14 09:10 +0200 |
| Message-ID | <tSaBb-25w-7@gated-at.bofh.it> (permalink) |
| References | <tPiEW-6IR-21@gated-at.bofh.it> <tPohj-20d-9@gated-at.bofh.it> <tRQMb-6li-29@gated-at.bofh.it> <tS58u-6WS-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/14/2017 09:15 AM, Masahiro Yamada wrote: > 2017-06-13 18:52 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>: >> Yamada-san, >> >> I have a question on the current top level Makefile. There are >> following lines, I have trouble to understand "firstword x$(MAKEFLAGS)" >> in 2nd line, why there is a 'x' there? >> >> >> ifneq ($(filter 4.%,$(MAKE_VERSION)),) # make-4 >> ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),) > > > I do not understand the 'x' either. > > Michal suggested the code according to the following: > https://patchwork.kernel.org/patch/3291301/ > (I hope Michal can help you.) > It does helps. > > My first guess was, it was added just in case $(MAKEFLAGS) is empty. > Actually $(firstword ) seems to work with empty argument, though. > I see, I guess you are saying it was added in case there is no single-letter flags in $(MAKEFLAGS) while it has "--debug=jobs", that make sense to me. Thanks very much, Yamada-san. -- Sincerely, Cao jin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] Kbuild: tiny correction on `make help` Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-06-13 12:00 +0200
Re: [PATCH v2] Kbuild: tiny correction on `make help` Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:20 +0200
Re: [PATCH v2] Kbuild: tiny correction on `make help` Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-06-14 09:10 +0200
Re: [PATCH v2] Kbuild: tiny correction on `make help` Michal Marek <mmarek@suse.com> - 2017-06-14 09:40 +0200
csiph-web