Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664666

Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error

Show all headers | View raw

On 09/06/2017 at 12:18:02 +0200, Arnd Bergmann wrote:
> When CONFIG_ARCH_AT91 is enabled, but none of the specific SoC support
> is in use, some at91 specific drivers fail to link:
> 
> drivers/tty/serial/atmel_serial.o: In function `atmel_serial_suspend':
> atmel_serial.c:(.text.atmel_serial_suspend+0x1e): undefined reference to `at91_suspend_entering_slow_clock'
> drivers/usb/host/ohci-at91.o: In function `ohci_hcd_at91_drv_suspend':
> ohci-at91.c:(.text.ohci_hcd_at91_drv_suspend+0x12): undefined reference to `at91_suspend_entering_slow_clock'
> drivers/usb/gadget/udc/at91_udc.o: In function `at91udc_suspend':
> at91_udc.c:(.text.at91udc_suspend+0x26): undefined reference to `at91_suspend_entering_slow_clock'
> 
> This changes the at91_suspend_entering_slow_clock hack once more, adding
> an alternative inline implementation that is used exactly in those cases
> that don't provide the normal implementation.
> 
> Fixes: c1892c2379d2 ("ARM: at91: handle CONFIG_PM for armv7m configurations")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/mach-at91/samv7.c          | 9 ---------
>  include/linux/platform_data/atmel.h | 7 +++++++
>  2 files changed, 7 insertions(+), 9 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:20 +0200
  Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link  error Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-09 13:50 +0200
    Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error Arnd Bergmann <arnd@arndb.de> - 2017-06-09 21:00 +0200
  Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link  error Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-13 12:00 +0200

csiph-web