Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662693

Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error
Date 2017-06-09 21:00 +0200
Message-ID <tQxiy-59d-23@gated-at.bofh.it> (permalink)
References <tQpbk-h3-13@gated-at.bofh.it> <tQqAr-Yw-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jun 9, 2017 at 1:44 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,
>
> On 09/06/2017 at 12:18:02 +0200, Arnd Bergmann wrote:
>> When CONFIG_ARCH_AT91 is enabled, but none of the specific SoC support
>> is in use, some at91 specific drivers fail to link:
>>
>> drivers/tty/serial/atmel_serial.o: In function `atmel_serial_suspend':
>> atmel_serial.c:(.text.atmel_serial_suspend+0x1e): undefined reference to `at91_suspend_entering_slow_clock'
>> drivers/usb/host/ohci-at91.o: In function `ohci_hcd_at91_drv_suspend':
>> ohci-at91.c:(.text.ohci_hcd_at91_drv_suspend+0x12): undefined reference to `at91_suspend_entering_slow_clock'
>> drivers/usb/gadget/udc/at91_udc.o: In function `at91udc_suspend':
>> at91_udc.c:(.text.at91udc_suspend+0x26): undefined reference to `at91_suspend_entering_slow_clock'
>>
>
> How you present it makes me think, that this was present for a while,
> even before samv7 support was added. Am I wrong?

I only ran into the problem after samv7 support was added. Before that,
pm.o was always built-in when CONFIG_AT91 was set, even when none
of the specific platforms got enabled.

       Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:20 +0200
  Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link  error Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-09 13:50 +0200
    Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link error Arnd Bergmann <arnd@arndb.de> - 2017-06-09 21:00 +0200
  Re: [PATCH] ARM: at91: fix at91_suspend_entering_slow_clock link  error Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-13 12:00 +0200

csiph-web