Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662697
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() |
| Date | 2017-06-09 21:10 +0200 |
| Message-ID | <tQxse-5ru-11@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tQs9d-22p-31@gated-at.bofh.it> <tQww9-4Rr-3@gated-at.bofh.it> <tQwPv-4Zo-7@gated-at.bofh.it> <tQwZc-52A-5@gated-at.bofh.it> <tQxiy-59d-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 09 Jun 2017 20:53:53 +0200 Paul Bolle <pebolle@tiscali.nl> wrote: > On Fri, 2017-06-09 at 14:32 -0400, Steven Rostedt wrote: > > I'm sure it works, but it just adds one more way of doing the same > > thing. I thought that was what perl was always criticized for, and why > > people usually prefer python. Don't get me wrong, I prefer oysters over > > snakes. But I just wanted to point out the lack of consistency here. > > A major benefit is that > #if IS_ENABLED(CONFIG_HYPERV) > > is shorter than > #if defined(CONFIG_HYPERV) || defined(CONFIG_HYPERV_MODULE) > > and less prone to typos. > I don't believe the module version is needed here. Otherwise I would question the #if altogether. Which now I'm looking at it, why is it needed? What includes this header file that wouldn't have that set anyway? The only place it is included is in: arch/x86/hyperv/mmu.c Is that compiled without CONFIG_HYPERV? -- Steve
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-09 15:30 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 20:10 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 20:30 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 20:40 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 20:50 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Paul Bolle <pebolle@tiscali.nl> - 2017-06-09 21:00 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 21:10 +0200
Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-12 05:00 +0200
csiph-web