Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()
Date	2017-06-09 20:40 +0200
Message-ID	<tQwZc-52A-5@gated-at.bofh.it> (permalink)
References	<tQs9c-22p-11@gated-at.bofh.it> <tQs9d-22p-31@gated-at.bofh.it> <tQww9-4Rr-3@gated-at.bofh.it> <tQwPv-4Zo-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 9 Jun 2017 21:23:52 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Jun 9, 2017 at 9:04 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri,  9 Jun 2017 15:27:36 +0200
> > Vitaly Kuznetsov <vkuznets@redhat.com> wrote:  
> 
> 
> >> +#if IS_ENABLED(CONFIG_HYPERV)  
> >
> > Hmm, this is new to me. I know you can use IS_ENABLED() inside C code,
> > but I've never seen it used for preprocessor directives. This usually
> > is just:
> >
> > #ifdef CONFIG_HYPERV
> >
> > Other than that, this looks fine to me.  
> 
> That is the magic of IS_ENABLED(), IS_BUILTIN() macros.
> So, the code above is fine as is.
> 

I'm sure it works, but it just adds one more way of doing the same
thing. I thought that was what perl was always criticized for, and why
people usually prefer python. Don't get me wrong, I prefer oysters over
snakes. But I just wanted to point out the lack of consistency here.

-- Steve

Thread

[PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-09 15:30 +0200
  Re: [PATCH v8 10/10] tracing/hyper-v: trace  hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 20:10 +0200
    Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 20:30 +0200
      Re: [PATCH v8 10/10] tracing/hyper-v: trace  hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 20:40 +0200
        Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 20:50 +0200
        Re: [PATCH v8 10/10] tracing/hyper-v: trace  hyperv_mmu_flush_tlb_others() Paul Bolle <pebolle@tiscali.nl> - 2017-06-09 21:00 +0200
          Re: [PATCH v8 10/10] tracing/hyper-v: trace  hyperv_mmu_flush_tlb_others() Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 21:10 +0200
            Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-12 05:00 +0200

csiph-web