Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662696
| From | Joe Lawrence <joe.lawrence@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] livepatch: add shadow variable sample program |
| Date | 2017-06-09 21:10 +0200 |
| Message-ID | <tQxsd-5ru-3@gated-at.bofh.it> (permalink) |
| References | <tND17-68x-3@gated-at.bofh.it> <tND18-68x-17@gated-at.bofh.it> <tQwZd-52A-35@gated-at.bofh.it> |
| Organization | Red Hat |
On 06/09/2017 02:38 PM, Josh Poimboeuf wrote:
> On Thu, Jun 01, 2017 at 02:25:26PM -0400, Joe Lawrence wrote:
>> [ ... snip ... ]
>> @@ -99,6 +130,12 @@ static int livepatch_init(void)
>>
>> static void livepatch_exit(void)
>> {
>> + struct task_ctr *nd, *tmp;
>> +
>> + list_for_each_entry_safe(nd, tmp, &shadow_list, list) {
>> + list_del(&nd->list);
>> + kfree(nd);
>> + }
>> WARN_ON(klp_unregister_patch(&patch));
>> }
>
> What does 'nd' stand for? I think a name like 'ctr' would be clearer.
>
Ah, in an earlier draft (pre-post) that data structure was called
"new_data", so "nd" was simply a short hand abbreviation. I'll update
for v2, thanks.
-- Joe
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 3/3] livepatch: add shadow variable sample program Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-09 20:40 +0200 Re: [PATCH 3/3] livepatch: add shadow variable sample program Joe Lawrence <joe.lawrence@redhat.com> - 2017-06-09 21:10 +0200
csiph-web