Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660172

Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

From Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups linux.kernel
Subject Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver
Date 2017-06-07 22:10 +0200
Message-ID <tPPrd-2PB-45@gated-at.bofh.it> (permalink)
References <tPlt8-aF-9@gated-at.bofh.it> <tPlt9-aF-31@gated-at.bofh.it> <tPHWF-6rv-9@gated-at.bofh.it> <tPJlM-7eC-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 07, 2017 at 04:37:12PM +0300, Andy Shevchenko wrote:
> >> +static acpi_status ti_pmic_common_handler(u32 function,
> > +                                       acpi_physical_address address,
> > +                                       u32 bits, u64 *value,
> > +                                       void *handler_context,
> 
> > handler_context is unused.
> 
> >> +                                                  int, int, u64 *),
> >> +                                       int (*update)(struct regmap *,
> >> +                                                     int, int, u64),
> >> +                                       struct ti_pmic_table *table,
> >> +                                       int table_size)
> 
> I would even split this to have separate update() and get() paths
> instead of having such a monster of parameters.

I'm not really worried about the two callbacks --- you have the compexity,
which is agruably rather manageable, split into a number of caller
functions. I'd rather keep it as-is.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] TPS68470 PMIC drivers  Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-06 14:10 +0200
  [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-06 14:10 +0200
    Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-06 16:30 +0200
      Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region  driver Hans de Goede <hdegoede@redhat.com> - 2017-06-06 17:30 +0200
        RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:30 +0200
      Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 14:20 +0200
        Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 15:50 +0200
          Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 22:20 +0200
            Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 22:50 +0200
              Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 23:20 +0200
                RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 01:40 +0200
                RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 02:20 +0200
            Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region  driver Hans de Goede <hdegoede@redhat.com> - 2017-06-08 09:10 +0200
              RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 01:50 +0200
      RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:30 +0200
    Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 14:10 +0200
      Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 15:40 +0200
        Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 22:10 +0200
          RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 02:10 +0200
        RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 02:10 +0200
      RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 02:10 +0200

csiph-web