Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662822

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

From "Mani, Rajmohan" <rajmohan.mani@intel.com>
Newsgroups linux.kernel
Subject RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver
Date 2017-06-10 01:40 +0200
Message-ID <tQBFv-7Sa-1@gated-at.bofh.it> (permalink)
References (3 earlier) <tPI6m-6wb-13@gated-at.bofh.it> <tPJvs-7jj-27@gated-at.bofh.it> <tPPAS-2SK-3@gated-at.bofh.it> <tPQ3U-34T-15@gated-at.bofh.it> <tPQwV-3ya-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Sakari, Andy,

> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@iki.fi]
> Sent: Wednesday, June 07, 2017 2:13 PM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Mani, Rajmohan <rajmohan.mani@intel.com>; Hans de Goede
> <hdegoede@redhat.com>; linux-kernel@vger.kernel.org; linux-
> gpio@vger.kernel.org; linux-acpi@vger.kernel.org; Lee Jones
> <lee.jones@linaro.org>; Linus Walleij <linus.walleij@linaro.org>; Alexandre
> Courbot <gnurou@gmail.com>; Rafael J. Wysocki <rjw@rjwysocki.net>; Len
> Brown <lenb@kernel.org>
> Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation
> region driver
> 
> On Wed, Jun 07, 2017 at 11:40:27PM +0300, Andy Shevchenko wrote:
> > On Wed, Jun 7, 2017 at 11:10 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > > On Wed, Jun 07, 2017 at 04:40:13PM +0300, Andy Shevchenko wrote:
> > >> On Wed, Jun 7, 2017 at 3:15 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > >> > On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote:
> >
> > >> >> Follow the pattern, please, I suppose ti_pmic_tps68470.c
> > >>
> > >> Would it work for you?
> > >
> > > This is still a different driver from the tps68470 driver which is
> > > an MFD driver. For clarity, I'd keep pmic as part of the name (and
> > > I'd use tps68470_pmic_ prefix for internal symbols, too).
> > >
> > > As PMICs are typically linked to the kernel (vs. being modules),
> > > there's no issue with the module name. I would suppose few if any
> > > PMICs will be compiled as modules in general.
> > >
> > > It's not a big deal though. I'm fine either way.
> >
> > Okay, let's agree on  tps68470_pmic for internal prefix and for file name?
> 
> Ack. Thanks!
> 

Ack

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 22:20 +0200
  Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 22:50 +0200
    Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 23:20 +0200
      RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 01:40 +0200
      RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 02:20 +0200
  Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region  driver Hans de Goede <hdegoede@redhat.com> - 2017-06-08 09:10 +0200
    RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation  region driver "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 01:50 +0200

csiph-web