Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656573

Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call
Date Fri, 02 Jun 2017 23:40:01 +0200
Message-ID <tO2sx-6xE-3@gated-at.bofh.it> (permalink)
References <tNWGv-2XT-33@gated-at.bofh.it>
X-Original-To Colin King <colin.king@canonical.com>
Dmarc-Filter OpenDMARC Filter v1.3.2 mx1.redhat.com 841E98124D
Authentication-Results ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com
Dkim-Filter OpenDKIM Filter v2.11.0 mx1.redhat.com 841E98124D
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
MIME-Version 1.0
Content-Type text/plain; charset="us-ascii"
Content-ID <21412.1496439464.1@warthog.procyon.org.uk>
X-Scanned-By MIMEDefang 2.79 on 10.5.11.15
X-Greylist Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 02 Jun 2017 21:37:46 +0000 (UTC)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 12
X-Original-Cc dhowells@redhat.com, "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Fri, 02 Jun 2017 22:37:44 +0100
X-Original-Message-ID <21413.1496439464@warthog.procyon.org.uk>
X-Original-References <20170602152227.3626-1-colin.king@canonical.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1656573

Show key headers only | View raw


Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The proc_remove call is dead code as it occurs after a return and
> hence can never be called. Remove it.
> 
> Detected by CoverityScan, CID#1437743 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: David Howells <dhowells@redhat.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH][net-next] rxrpc: remove redundant proc_remove call Colin King <colin.king@canonical.com> - 2017-06-02 17:30 +0200
  Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Howells <dhowells@redhat.com> - 2017-06-02 23:40 +0200
  Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200

csiph-web