Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: David Howells Newsgroups: linux.kernel Subject: Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call Date: Fri, 02 Jun 2017 23:40:01 +0200 Message-ID: References: X-Original-To: Colin King Dmarc-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 841E98124D Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com Dkim-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 841E98124D Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21412.1496439464.1@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 02 Jun 2017 21:37:46 +0000 (UTC) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 12 X-Original-Cc: dhowells@redhat.com, "David S . Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Fri, 02 Jun 2017 22:37:44 +0100 X-Original-Message-ID: <21413.1496439464@warthog.procyon.org.uk> X-Original-References: <20170602152227.3626-1-colin.king@canonical.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1656573 Colin King wrote: > From: Colin Ian King > > The proc_remove call is dead code as it occurs after a return and > hence can never be called. Remove it. > > Detected by CoverityScan, CID#1437743 ("Logically dead code") > > Signed-off-by: Colin Ian King Acked-by: David Howells