Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656341

[PATCH][net-next] rxrpc: remove redundant proc_remove call

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The proc_remove call is dead code as it occurs after a return and
hence can never be called. Remove it.

Detected by CoverityScan, CID#1437743 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/rxrpc/net_ns.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/rxrpc/net_ns.c b/net/rxrpc/net_ns.c
index 26449a6bb076..7edceb8522f5 100644
--- a/net/rxrpc/net_ns.c
+++ b/net/rxrpc/net_ns.c
@@ -59,7 +59,6 @@ static __net_init int rxrpc_init_net(struct net *net)
 	proc_create("conns", 0444, rxnet->proc_net, &rxrpc_connection_seq_fops);
 	return 0;
 
-	proc_remove(rxnet->proc_net);
 err_proc:
 	return ret;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] rxrpc: remove redundant proc_remove call Colin King <colin.king@canonical.com> - 2017-06-02 17:30 +0200
  Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Howells <dhowells@redhat.com> - 2017-06-02 23:40 +0200
  Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200

csiph-web