Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656582
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Suman Anna <s-anna@ti.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops |
| Date | Fri, 02 Jun 2017 23:50:01 +0200 |
| Message-ID | <tO2Cd-6B6-5@gated-at.bofh.it> (permalink) |
| References | <tNT5T-rX-13@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1496439616; bh=OsLjRHDlJ2KJQopQCOMXWrSknTjWo6flNNFACvD5f3U=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=GWGcnll3czhPuKQCE7jNvUPMEa+OqFK+bQFjSEDmg06S3+wIvvK11gizFPxxuDEYe RNp7VVCCgehdDZGcgs5EZOErieul2YB8woecAayou0hck7v0vl4x2Ky4lQQhGo12Ak 5UPfFTwverIkiOFlBzpKu5Kp9YYRJyHBy/cImghQ= |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="windows-1252" |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, open list <linux-kernel@vger.kernel.org> |
| X-Original-Date | Fri, 2 Jun 2017 16:40:15 -0500 |
| X-Original-Message-ID | <053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com> |
| X-Original-References | <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1656582 |
Show key headers only | View raw
On 06/02/2017 06:36 AM, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com> Acked-by: Suman Anna <s-anna@ti.com> > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; >
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Henri Roosen <henri.roosen@ginzinger.com> - 2017-06-02 13:40 +0200 Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Suman Anna <s-anna@ti.com> - 2017-06-02 23:50 +0200
csiph-web