Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops

From	Suman Anna <s-anna@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
Date	2017-06-02 23:50 +0200
Message-ID	<tO2Cd-6B6-5@gated-at.bofh.it> (permalink)
References	<tNT5T-rX-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/02/2017 06:36 AM, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
> 
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
>  drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
>  	/* Link the channel to our vrp */
>  	vch->vrp = vrp;
>  
> -	/* Assign callbacks for rpmsg_channel */
> -	vch->rpdev.ops = &virtio_rpmsg_ops;
> -
>  	/* Assign public information to the rpmsg_device */
>  	rpdev = &vch->rpdev;
>  	rpdev->src = chinfo->src;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Henri Roosen <henri.roosen@ginzinger.com> - 2017-06-02 13:40 +0200
  Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to  ops Suman Anna <s-anna@ti.com> - 2017-06-02 23:50 +0200

csiph-web