Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Suman Anna Newsgroups: linux.kernel Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Date: Fri, 02 Jun 2017 23:50:01 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1496439616; bh=OsLjRHDlJ2KJQopQCOMXWrSknTjWo6flNNFACvD5f3U=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=GWGcnll3czhPuKQCE7jNvUPMEa+OqFK+bQFjSEDmg06S3+wIvvK11gizFPxxuDEYe RNp7VVCCgehdDZGcgs5EZOErieul2YB8woecAayou0hck7v0vl4x2Ky4lQQhGo12Ak 5UPfFTwverIkiOFlBzpKu5Kp9YYRJyHBy/cImghQ= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 27 Organization: linux.* mail to news gateway X-Original-Cc: Ohad Ben-Cohen , Bjorn Andersson , open list X-Original-Date: Fri, 2 Jun 2017 16:40:15 -0500 X-Original-Message-ID: <053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com> X-Original-References: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1656582 On 06/02/2017 06:36 AM, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen Acked-by: Suman Anna > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; >