Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655109

Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date 2017-06-01 14:50 +0200
Message-ID <tNxI5-2Aw-9@gated-at.bofh.it> (permalink)
References (1 earlier) <tMMpP-63R-11@gated-at.bofh.it> <tMQjM-8vK-17@gated-at.bofh.it> <tNwM1-21A-3@gated-at.bofh.it> <tNxoK-2tN-5@gated-at.bofh.it> <tNxyr-2x0-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 01, 2017 at 03:36:50PM +0300, Rakesh Pandit wrote:
> Also Sagi pointed out that user space set_features ioctl if fired up
> in a window after nvme_removal it can also result in this issue seems
> to be correct.  I would prefer to keep this as it is and introduce
> similar check higher up in nvme_ioctrl instead so that we don't send
> sync commands if queues are killed already.
> 
> Would you prefer a patch ? Thanks,

If we want to kill everyone we probably should do it in ->queue_rq.
Or is the block layer blocking you somewhere else?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for  ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 09:20 +0200
  Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-05-30 11:40 +0200
  Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-05-30 12:20 +0200
    Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 16:30 +0200
      Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 13:50 +0200
        Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:30 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:40 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:40 +0200
            Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:50 +0200
              Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Ming Lei <ming.lei@redhat.com> - 2017-06-01 17:00 +0200
                Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 21:40 +0200
                Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Ming Lei <ming.lei@redhat.com> - 2017-06-02 03:50 +0200
        Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:30 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-05 10:20 +0200
            Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-05 13:00 +0200
              Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-05 13:10 +0200

csiph-web