Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1655694
| From | Rakesh Pandit <rakesh@tuxera.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever |
| Date | 2017-06-01 21:40 +0200 |
| Message-ID | <tNE6S-6SI-17@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <tNwM1-21A-3@gated-at.bofh.it> <tNxoK-2tN-5@gated-at.bofh.it> <tNxyr-2x0-29@gated-at.bofh.it> <tNxI5-2Aw-9@gated-at.bofh.it> <tNzJV-3Qo-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 01, 2017 at 10:56:10PM +0800, Ming Lei wrote:
> On Thu, Jun 01, 2017 at 02:46:32PM +0200, Christoph Hellwig wrote:
> > On Thu, Jun 01, 2017 at 03:36:50PM +0300, Rakesh Pandit wrote:
> > > Also Sagi pointed out that user space set_features ioctl if fired up
> > > in a window after nvme_removal it can also result in this issue seems
> > > to be correct. I would prefer to keep this as it is and introduce
> > > similar check higher up in nvme_ioctrl instead so that we don't send
> > > sync commands if queues are killed already.
> > >
> > > Would you prefer a patch ? Thanks,
> >
> > If we want to kill everyone we probably should do it in ->queue_rq.
>
> Looks ->queue_rq has done it already via checking nvmeq->cq_vector
>
> > Or is the block layer blocking you somewhere else?
>
> blk-mq doesn't handle dying in the I/O path.
>
> Maybe it is similar with 806f026f9b901eaf1a(nvme: use blk_mq_start_hw_queues() in
> nvme_kill_queues()), seems we need to do it for admin_q too.
>
> Can the following change fix the issue?
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index e44326d5cf19..360758488124 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2438,6 +2438,7 @@ void nvme_kill_queues(struct nvme_ctrl *ctrl)
> struct nvme_ns *ns;
>
> mutex_lock(&ctrl->namespaces_mutex);
> + blk_mq_start_hw_queues(ctrl->admin_q);
> list_for_each_entry(ns, &ctrl->namespaces, list) {
> /*
> * Revalidating a dead namespace sets capacity to 0. This will
>
>
Yes change fixes the issue.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 09:20 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Christoph Hellwig <hch@lst.de> - 2017-05-30 11:40 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Sagi Grimberg <sagi@grimberg.me> - 2017-05-30 12:20 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 16:30 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 13:50 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:30 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:40 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:40 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:50 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Ming Lei <ming.lei@redhat.com> - 2017-06-01 17:00 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 21:40 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Ming Lei <ming.lei@redhat.com> - 2017-06-02 03:50 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:30 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-05 10:20 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-05 13:00 +0200
Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-05 13:10 +0200
csiph-web