Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653072

Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever

From Sagi Grimberg <sagi@grimberg.me>
Newsgroups linux.kernel
Subject Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date 2017-05-30 12:20 +0200
Message-ID <tMMpP-63R-11@gated-at.bofh.it> (permalink)
References <tMJBD-49a-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>  	/*
> +	 * Avoid configuration and syncing commands if controller is already
> +	 * being removed and queues have been killed.
> +	 */
> +	if (ctrl->state == NVME_CTRL_DELETING || ctrl->state == NVME_CTRL_DEAD)
> +		return;
> +

Hey Rakesh, Christoph,

Given that the issue is for sync command submission during controller
removal, I'm wandering if we should perhaps move this check to
__nvme_submit_sync_cmd?

AFAICT user-space can just as easily trigger set_features in the same
condition which will trigger the hang couldn't it?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for  ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 09:20 +0200
  Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-05-30 11:40 +0200
  Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-05-30 12:20 +0200
    Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 16:30 +0200
      Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 13:50 +0200
        Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:30 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:40 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 14:40 +0200
            Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-01 14:50 +0200
              Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Ming Lei <ming.lei@redhat.com> - 2017-06-01 17:00 +0200
                Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-01 21:40 +0200
                Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Ming Lei <ming.lei@redhat.com> - 2017-06-02 03:50 +0200
        Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:30 +0200
          Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-06-05 10:20 +0200
            Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-06-05 13:00 +0200
              Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep  for ever Sagi Grimberg <sagi@grimberg.me> - 2017-06-05 13:10 +0200

csiph-web