Re: perf group read for inherited events

From	Vince Weaver <vince@deater.net>
Newsgroups	linux.kernel
Subject	Re: perf group read for inherited events
Date	2017-05-30 21:10 +0200
Message-ID	<tMUx4-2xi-21@gated-at.bofh.it> (permalink)
References	<tMLWN-5BU-7@gated-at.bofh.it> <tMLWN-5BU-5@gated-at.bofh.it> <tMPQJ-861-7@gated-at.bofh.it> <tMSOC-1GK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 30 May 2017, Peter Zijlstra wrote:

> On Tue, May 30, 2017 at 06:57:14AM -0700, Andi Kleen wrote:
> > On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote:
> > > > Or is the simple patch below good enough?
> > > 
> > > The below seems to be the correct thing. It is rather unfortunate that
> > > this would break/significantly change existing semantics :/
> > 
> > The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type,
> > even though it wasn't implemented? It seems reasonable to me.
> 
> Right, so where we used to accept PERF_SAMPLE_READ on inherited events,
> we now no longer will.
> 
> Note that it currently doesn't work right, even if it doesn't fail like
> with the proposed patch.
> 
> Typically Vince will (rightly) complain when I change things like this.
> But seeing how even if we accept it, it is fairly terminally buggered in
> any case, we could change it.
> 
> Vince, do you know of anybody that would be immediately affected by
> this?

I often only hear about breakage months later after it's too late.

So the issue is currently if you were sampling, and you were sampling on
an event group, and you had set PERF_SAMPLE_READ to get all counts for a 
group, and the event was also inherited.... perf_event_open() would let 
you do this even though the results would probably be wrong?

I'm not aware of anyone trying to do this, or at least I should say PAPI 
isn't trying to do this (PAPI currently has pretty simplistic sampling 
support, though that's getting a major overhaul this summer).

Vince

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 11:50 +0200
  Re: perf group read for inherited events Andi Kleen <ak@linux.intel.com> - 2017-05-30 16:00 +0200
    Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 19:10 +0200
      Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 21:00 +0200
        Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-31 23:10 +0200
      Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-30 21:10 +0200

csiph-web