Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653406

Re: perf group read for inherited events

Show all headers | View raw

On Tue, May 30, 2017 at 06:57:14AM -0700, Andi Kleen wrote:
> On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote:
> > > Or is the simple patch below good enough?
> > 
> > The below seems to be the correct thing. It is rather unfortunate that
> > this would break/significantly change existing semantics :/
> 
> The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type,
> even though it wasn't implemented? It seems reasonable to me.

Right, so where we used to accept PERF_SAMPLE_READ on inherited events,
we now no longer will.

Note that it currently doesn't work right, even if it doesn't fail like
with the proposed patch.

Typically Vince will (rightly) complain when I change things like this.
But seeing how even if we accept it, it is fairly terminally buggered in
any case, we could change it.

Vince, do you know of anybody that would be immediately affected by
this?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 11:50 +0200
  Re: perf group read for inherited events Andi Kleen <ak@linux.intel.com> - 2017-05-30 16:00 +0200
    Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 19:10 +0200
      Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 21:00 +0200
        Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-31 23:10 +0200
      Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-30 21:10 +0200

csiph-web