Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653255
| From | Andi Kleen <ak@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: perf group read for inherited events |
| Date | 2017-05-30 16:00 +0200 |
| Message-ID | <tMPQJ-861-7@gated-at.bofh.it> (permalink) |
| References | <tMLWN-5BU-7@gated-at.bofh.it> <tMLWN-5BU-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote: > > Or is the simple patch below good enough? > > The below seems to be the correct thing. It is rather unfortunate that > this would break/significantly change existing semantics :/ The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type, even though it wasn't implemented? It seems reasonable to me. If you really worry about it could drop a printk_once in and see if it triggers anywhere (and if yes drop the if completely) The patch looks good to me. Please consider adding it. I have some patches to use this in perf stat, will submit later. -Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 11:50 +0200
Re: perf group read for inherited events Andi Kleen <ak@linux.intel.com> - 2017-05-30 16:00 +0200
Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 19:10 +0200
Re: perf group read for inherited events Peter Zijlstra <peterz@infradead.org> - 2017-05-30 21:00 +0200
Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-31 23:10 +0200
Re: perf group read for inherited events Vince Weaver <vince@deater.net> - 2017-05-30 21:10 +0200
csiph-web