Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1649083

Re: CHIPPro NAND issue with 4.12 rc1

From Angus Ainslie <angus@akkea.ca>
Newsgroups linux.kernel
Subject Re: CHIPPro NAND issue with 4.12 rc1
Date 2017-05-24 06:10 +0200
Message-ID <tKvMt-5sv-3@gated-at.bofh.it> (permalink)
References (2 earlier) <tJk6J-6RI-1@gated-at.bofh.it> <tJrUB-3Hm-1@gated-at.bofh.it> <tJPDA-2me-7@gated-at.bofh.it> <tJYxb-83k-13@gated-at.bofh.it> <tKo8i-7OL-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017-05-23 13:52, Maxime Ripard wrote:
> 
> Ok, good.
> 
> If you unrevert those patches, and add clk_ignore_unused to the kernel
> command line, is it still broken?
> 
> Maxime


If I use the clk_ignore_unused flag with the patches below then the 
kernel can boot and mount the nand.

diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c 
b/drivers/clk/sunxi-ng/ccu-sun5i.c
index 5c476f9..700944c 100644
--- a/drivers/clk/sunxi-ng/ccu-sun5i.c
+++ b/drivers/clk/sunxi-ng/ccu-sun5i.c
@@ -251,7 +251,7 @@ static SUNXI_CCU_GATE(ahb_mmc1_clk, "ahb-mmc1",     
"ahb",
  static SUNXI_CCU_GATE(ahb_mmc2_clk,    "ahb-mmc2",     "ahb",
                       0x060, BIT(10), 0);
  static SUNXI_CCU_GATE(ahb_nand_clk,    "ahb-nand",     "ahb",
-                     0x060, BIT(13), 0);
+                     0x060, BIT(13), CLK_IS_CRITICAL);
  static SUNXI_CCU_GATE(ahb_sdram_clk,   "ahb-sdram",    "ahb",
                       0x060, BIT(14), CLK_IS_CRITICAL);
  static SUNXI_CCU_GATE(ahb_emac_clk,    "ahb-emac",     "ahb",


diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts 
b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
index c55b11a..fa37cce 100644
--- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
+++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
@@ -146,6 +149,32 @@
                 reg = <0>;
                 allwinner,rb = <0>;
                 nand-ecc-mode = "hw";
+    nand-on-flash-bbt;
+
+    spl@0 {
+      label = "SPL";
+      reg = /bits/ 64 <0x0 0x400000>;
+    };
+
+    spl-backup@400000 {
+      label = "SPL.backup";
+      reg = /bits/ 64 <0x400000 0x400000>;
+    };
+
+    u-boot@800000 {
+      label = "U-Boot";
+      reg = /bits/ 64 <0x800000 0x400000>;
+    };
+
+    env@c00000 {
+      label = "env";
+      reg = /bits/ 64 <0xc00000 0x400000>;
+    };
+
+    rootfs@1000000 {
+      label = "rootfs";
+      reg = /bits/ 64 <0x1000000 0x1f000000>;
+    };
         };
  };

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-20 17:00 +0200
  Re: CHIPPro NAND issue with 4.12 rc1 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-20 17:20 +0200
    Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-20 23:30 +0200
      Re: CHIPPro NAND issue with 4.12 rc1 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-21 07:50 +0200
        Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-22 07:00 +0200
        Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-22 09:10 +0200
          Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-22 18:40 +0200
            Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-23 22:00 +0200
              Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 00:50 +0200
              Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 06:10 +0200
                Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-24 08:40 +0200
                Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 13:50 +0200

csiph-web