Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649154

Re: CHIPPro NAND issue with 4.12 rc1

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: CHIPPro NAND issue with 4.12 rc1
Date 2017-05-24 08:40 +0200
Message-ID <tKy7E-75H-11@gated-at.bofh.it> (permalink)
References (3 earlier) <tJrUB-3Hm-1@gated-at.bofh.it> <tJPDA-2me-7@gated-at.bofh.it> <tJYxb-83k-13@gated-at.bofh.it> <tKo8i-7OL-15@gated-at.bofh.it> <tKvMt-5sv-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, May 23, 2017 at 10:05:14PM -0600, Angus Ainslie wrote:
> On 2017-05-23 13:52, Maxime Ripard wrote:
> > 
> > Ok, good.
> > 
> > If you unrevert those patches, and add clk_ignore_unused to the kernel
> > command line, is it still broken?
> > 
> > Maxime
> 
> 
> If I use the clk_ignore_unused flag with the patches below then the kernel
> can boot and mount the nand.
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c
> b/drivers/clk/sunxi-ng/ccu-sun5i.c
> index 5c476f9..700944c 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun5i.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun5i.c
> @@ -251,7 +251,7 @@ static SUNXI_CCU_GATE(ahb_mmc1_clk, "ahb-mmc1",
> "ahb",
>  static SUNXI_CCU_GATE(ahb_mmc2_clk,    "ahb-mmc2",     "ahb",
>                       0x060, BIT(10), 0);
>  static SUNXI_CCU_GATE(ahb_nand_clk,    "ahb-nand",     "ahb",
> -                     0x060, BIT(13), 0);
> +                     0x060, BIT(13), CLK_IS_CRITICAL);
>  static SUNXI_CCU_GATE(ahb_sdram_clk,   "ahb-sdram",    "ahb",
>                       0x060, BIT(14), CLK_IS_CRITICAL);
>  static SUNXI_CCU_GATE(ahb_emac_clk,    "ahb-emac",     "ahb",

That doesn't really make much sense, clk_ignore_unused and
CLK_IS_CRITICAL are roughly doing the same thing

Could you paste the whole kernel logs?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-20 17:00 +0200
  Re: CHIPPro NAND issue with 4.12 rc1 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-20 17:20 +0200
    Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-20 23:30 +0200
      Re: CHIPPro NAND issue with 4.12 rc1 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-21 07:50 +0200
        Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-22 07:00 +0200
        Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-22 09:10 +0200
          Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-22 18:40 +0200
            Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-23 22:00 +0200
              Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 00:50 +0200
              Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 06:10 +0200
                Re: CHIPPro NAND issue with 4.12 rc1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-24 08:40 +0200
                Re: CHIPPro NAND issue with 4.12 rc1 Angus Ainslie <angus@akkea.ca> - 2017-05-24 13:50 +0200

csiph-web