Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode
Date	2017-05-25 10:20 +0200
Message-ID	<tKW9Y-5J4-23@gated-at.bofh.it> (permalink)
References	<tKcTv-a4-3@gated-at.bofh.it> <tKcTw-a4-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:

SNIP

>  };
>  
> @@ -488,6 +489,12 @@ struct time_conv_event {
>  	u64 time_zero;
>  };
>  
> +struct feature_event {
> +	struct perf_event_header header;
> +	u64 header_id;
> +	char data[]; /* size bytes of raw data specific to the feature */
> +};

please align the members, like it's in structs around

struct feature_event {
	struct perf_event_header	header;
	u64				header_id;
	char				data[];
}

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-23 10:00 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Namhyung Kim <namhyung@kernel.org> - 2017-05-24 17:50 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:10 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
    Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-06 03:40 +0200
      Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-06 13:10 +0200
        Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-06 20:20 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
    Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-06 13:10 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200

csiph-web