Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650283
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode |
| Date | 2017-05-25 10:20 +0200 |
| Message-ID | <tKW9X-5J4-21@gated-at.bofh.it> (permalink) |
| References | <tKcTv-a4-3@gated-at.bofh.it> <tKcTw-a4-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:
SNIP
> + for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> + if (!feat_ops[feat].has_record) {
> + pr_debug("No record header feature for header :%d\n", feat);
> + continue;
> + }
> +
> + fdd.offset = sizeof(*fe);
> +
> + ret = feat_ops[feat].write(&fdd, evlist);
> + if (ret || fdd.offset <= (ssize_t)sizeof(*fe)) {
> + pr_debug("Error writing feature\n");
> + continue;
> + }
> +
> + /* fdd.buf may have changed due to realloc in do_write() */
> + fe = fdd.buf;
> + memset(fe, 0, sizeof(*fe));
no need to wipe it out if you set all the members just below
(apart from header.misc, which is not used)
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-23 10:00 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Namhyung Kim <namhyung@kernel.org> - 2017-05-24 17:50 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:10 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-06 03:40 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-06 13:10 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-06-06 20:20 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-06 13:10 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
csiph-web