Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658637

Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode

Show all headers | View raw

On Tue, Jun 06, 2017 at 12:57:53AM +0000, David Carrillo-Cisneros wrote:
> On Thu, May 25, 2017 at 1:09 AM Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:
> >
> > SNIP
> >
> > > +     for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> > > +             if (!feat_ops[feat].has_record) {
> > > +                     pr_debug("No record header feature for header
> > :%d\n", feat);
> > > +                     continue;
> > > +             }
> > > +
> > > +             fdd.offset = sizeof(*fe);
> > > +
> > > +             ret = feat_ops[feat].write(&fdd, evlist);
> > > +             if (ret || fdd.offset <= (ssize_t)sizeof(*fe)) {
> > > +                     pr_debug("Error writing feature\n");
> > > +                     continue;
> > > +             }
> > > +
> > > +             /* fdd.buf may have changed due to realloc in do_write() */
> > > +             fe = fdd.buf;
> > > +             memset(fe, 0, sizeof(*fe));
> >
> > no need to wipe it out if you set all the members just below
> > (apart from header.misc, which is not used)
> >
> 
> what if that changes one day? isn't it better to zero to avoid hard to find
> bugs?

ok

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-25 10:20 +0200
  Re: [PATCH v2 13/13] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-06-06 13:10 +0200

csiph-web