Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1649849
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() |
| Date | 2017-05-24 20:20 +0200 |
| Message-ID | <tKJ34-5LE-13@gated-at.bofh.it> (permalink) |
| References | <tKHDX-4Jq-11@gated-at.bofh.it> <tKIA2-5m6-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>
>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> if (!ctx) {
>> - dev_err(&pdev->dev, "no memory for pcictl context\n");
>> ret = -ENOMEM;
>> goto out;
>> }
>> --
>> 2.13.0
>
> Why are you removing just this one dev_err()?
How do you think about to achieve a small code reduction also for this software module?
> What issue are you trying to address?
Do you find information from a Linux allocation failure report sufficient
for such a function implementation?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 18:50 +0200
Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-24 19:50 +0200
Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:20 +0200
Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() Randy Dunlap <rdunlap@infradead.org> - 2017-05-24 20:30 +0200
Re: MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 22:30 +0200
Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-25 08:30 +0200
Re: MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-25 09:00 +0200
Re: MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-25 11:40 +0200
Re: MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-25 13:00 +0200
csiph-web