Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649828

Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe()

Show all headers | View raw

On Wed, May 24, 2017 at 6:42 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 24 May 2017 18:32:21 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/mips/pci/pci-alchemy.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/pci/pci-alchemy.c b/arch/mips/pci/pci-alchemy.c
> index e99ca7702d8a..a58c3290bd4e 100644
> --- a/arch/mips/pci/pci-alchemy.c
> +++ b/arch/mips/pci/pci-alchemy.c
> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>
>         ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>         if (!ctx) {
> -               dev_err(&pdev->dev, "no memory for pcictl context\n");
>                 ret = -ENOMEM;
>                 goto out;
>         }
> --
> 2.13.0

Why are you removing just this one dev_err()?  What issue are you
trying to address?

Manuel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: Alchemy: Delete an error message for a failed memory  allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 18:50 +0200
  Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed  memory allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-24 19:50 +0200
    Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed  memory allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:20 +0200
      Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed  memory allocation in alchemy_pci_probe() Randy Dunlap <rdunlap@infradead.org> - 2017-05-24 20:30 +0200
        Re: MIPS: Alchemy: Delete an error message for a failed memory  allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 22:30 +0200
      Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed  memory allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-25 08:30 +0200
        Re: MIPS: Alchemy: Delete an error message for a failed memory  allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-25 09:00 +0200
          Re: MIPS: Alchemy: Delete an error message for a failed memory  allocation in alchemy_pci_probe() Manuel Lauss <manuel.lauss@gmail.com> - 2017-05-25 11:40 +0200
            Re: MIPS: Alchemy: Delete an error message for a failed memory  allocation in alchemy_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-25 13:00 +0200

csiph-web