Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1649521

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

From Milian Wolff <milian.wolff@kdab.com>
Newsgroups linux.kernel
Subject Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix
Date 2017-05-24 13:50 +0200
Message-ID <tKCXF-1Q9-21@gated-at.bofh.it> (permalink)
References <tIzrb-7No-3@gated-at.bofh.it> <tIzrb-7No-7@gated-at.bofh.it> <tJUWC-5LA-1@gated-at.bofh.it>
Organization KDAB

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Monday, May 22, 2017 2:48:18 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> > The original patch that introduced inline frame output in the
> > various browsers used this suffix already. The new centralized
> > approach that uses fake symbols for inlined frames was missing
> > this approach so far.
> > 
> > Instead of changing the symbol name itself, we only print the
> > suffix where needed. This allows us to efficiently lookup
> > the symbol for a given name without first having to append the
> > suffix before the lookup.
> 
> You also need to do same thing for hist_entry__sym_snprintf().

Thank you, will do!

-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-05-18 21:40 +0200
  Re: [PATCH 6/7] perf report: mark inlined frames in output by "  (inlined)" suffix Namhyung Kim <namhyung@kernel.org> - 2017-05-22 14:50 +0200
    Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-05-24 13:50 +0200
    Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-06-03 16:00 +0200
      Re: [PATCH 6/7] perf report: mark inlined frames in output by "  (inlined)" suffix Namhyung Kim <namhyung@kernel.org> - 2017-06-06 03:40 +0200
        Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-06-06 09:30 +0200
          Re: [PATCH 6/7] perf report: mark inlined frames in output by "  (inlined)" suffix Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-06 22:00 +0200

csiph-web