Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

From	Milian Wolff <milian.wolff@kdab.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them
Date	2017-05-24 13:50 +0200
Message-ID	<tKCXE-1Q9-19@gated-at.bofh.it> (permalink)
References	<tIzrb-7No-3@gated-at.bofh.it> <tIzrc-7No-25@gated-at.bofh.it> <tJUtz-5zo-3@gated-at.bofh.it>
Organization	KDAB

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Monday, May 22, 2017 2:11:58 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:11PM +0200, Milian Wolff wrote:
> > Instead of showing the (repeated) DSO name of the non-inlined
> > frame, we now show the "(inlined)" suffix instead.
> > 
> > Before:
> >                    214f7 __hypot_finite (/usr/lib/libm-2.25.so)
> >                    
> >                     ace3 hypot (/usr/lib/libm-2.25.so)
> >                     
> >                          std::__complex_abs
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::abs<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::_Norm_helper<true>::_S_do_it<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::norm<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                      
> >                      a4a main
> >                      (/home/milian/projects/src/perf-tests/inlining)
> >                    
> >                    20510 __libc_start_main (/usr/lib/libc-2.25.so)
> >                    
> >                      bd9 _start
> >                      (/home/milian/projects/src/perf-tests/inlining)
> > 
> > After:
> >                    214f7 __hypot_finite (/usr/lib/libm-2.25.so)
> >                    
> >                     ace3 hypot (/usr/lib/libm-2.25.so)
> >                     
> >                          std::__complex_abs (inlined)
> >                          std::abs<double> (inlined)
> >                          std::_Norm_helper<true>::_S_do_it<double>
> >                          (inlined)
> >                          std::norm<double> (inlined)
> 
> Shouldn't they have 'a4a' too?

Yes, I think I forgot to update the commit message after I changed the 
behavior to keep compatibility with stackcollapse-perf.pl.

Will update the message.

Thanks

-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 7/7] perf script: mark inlined frames and do not print DSO for them Milian Wolff <milian.wolff@kdab.com> - 2017-05-18 21:40 +0200
  Re: [PATCH 7/7] perf script: mark inlined frames and do not print  DSO for them Namhyung Kim <namhyung@kernel.org> - 2017-05-22 14:20 +0200
    Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them Milian Wolff <milian.wolff@kdab.com> - 2017-05-24 13:50 +0200

csiph-web