Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646842

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

Show all headers | View raw

On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> The original patch that introduced inline frame output in the
> various browsers used this suffix already. The new centralized
> approach that uses fake symbols for inlined frames was missing
> this approach so far.
> 
> Instead of changing the symbol name itself, we only print the
> suffix where needed. This allows us to efficiently lookup
> the symbol for a given name without first having to append the
> suffix before the lookup.

You also need to do same thing for hist_entry__sym_snprintf().

Thanks,
Namhyung


> 
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Yao Jin <yao.jin@linux.intel.com>
> Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
> ---
>  tools/perf/util/callchain.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index 211ed3713fac..4350c7ceaca1 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -1061,11 +1061,15 @@ char *callchain_list__sym_name(struct callchain_list *cl,
>  	int printed;
>  
>  	if (cl->ms.sym) {
> +		const char *inlined = cl->ms.sym->inlined ? " (inlined)" : "";
> +
>  		if (show_srcline && cl->srcline)
> -			printed = scnprintf(bf, bfsize, "%s %s",
> -					cl->ms.sym->name, cl->srcline);
> +			printed = scnprintf(bf, bfsize, "%s %s%s",
> +					    cl->ms.sym->name, cl->srcline,
> +					    inlined);
>  		else
> -			printed = scnprintf(bf, bfsize, "%s", cl->ms.sym->name);
> +			printed = scnprintf(bf, bfsize, "%s%s",
> +					    cl->ms.sym->name, inlined);
>  	} else
>  		printed = scnprintf(bf, bfsize, "%#" PRIx64, cl->ip);
>  
> -- 
> 2.13.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-05-18 21:40 +0200
  Re: [PATCH 6/7] perf report: mark inlined frames in output by "  (inlined)" suffix Namhyung Kim <namhyung@kernel.org> - 2017-05-22 14:50 +0200
    Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff <milian.wolff@kdab.com> - 2017-05-24 13:50 +0200

csiph-web