Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services
Date	2017-05-21 10:40 +0200
Message-ID	<tJuz8-5rf-9@gated-at.bofh.it> (permalink)
References	<tIr0C-147-11@gated-at.bofh.it> <tIrai-18m-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> +		 *
> +		 * pci_irq_vector() below is able to handle entry differently
> +		 * depending on MSI vs MSI-x case
> +		 *
>  		 */

One more instance of this comment left :)

>  		pcie_capability_read_word(dev, PCI_EXP_FLAGS, &reg16);
>  		entry = (reg16 & PCI_EXP_FLAGS_IRQ) >> 9;
> @@ -100,7 +107,10 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *irqs, int mask)
>  		 * MSI/MSI-X vectors assigned to the port is going to be used
>  		 * for AER, where "For MSI-X, the value in this register
>  		 * indicates which MSI-X Table entry is used to generate the
> -		 * interrupt message."
> +		 * interrupt message."  and "For MSI, the value
> +		 * in this field indicates the offset between the base Message
> +		 * Data and the interrupt message that is generated."
> +		 *
>  		 */

And while this is getting a little too deep into nitpicking:  we usually
don't add empty lines to the end of comments.

Thread

[PATCH v3 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-18 12:40 +0200
  [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-18 12:50 +0200
    Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI  interrupts for PCIe port services Christoph Hellwig <hch@infradead.org> - 2017-05-21 10:40 +0200
      RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI  interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-21 17:10 +0200
        Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI  interrupts for PCIe port services Christoph Hellwig <hch@infradead.org> - 2017-05-22 19:50 +0200
          RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI  interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-23 16:30 +0200

csiph-web