Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647217
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services |
| Date | 2017-05-22 19:50 +0200 |
| Message-ID | <tJZCV-dH-1@gated-at.bofh.it> (permalink) |
| References | <tIr0C-147-11@gated-at.bofh.it> <tIrai-18m-19@gated-at.bofh.it> <tJuz8-5rf-9@gated-at.bofh.it> <tJAEy-Yo-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, May 21, 2017 at 03:00:46PM +0000, Gabriele Paoloni wrote: > > I thought that in your previous review you meant to say that we should > avoid 2 instances of the same comment (in this patchset I only have this > instance as I have removed the same comment from patch 2/2...) No, there is no pointin the comment. The whole point of pci_irq_vector is to abstract away from how to get at the interrupt in detail. There is no need to comment on this at the callsite. If you think the existing documentation for the function is not good enough send a patch to improve it there instead of commenting the callsites.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-18 12:40 +0200
[PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-18 12:50 +0200
Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Christoph Hellwig <hch@infradead.org> - 2017-05-21 10:40 +0200
RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-21 17:10 +0200
Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Christoph Hellwig <hch@infradead.org> - 2017-05-22 19:50 +0200
RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-05-23 16:30 +0200
csiph-web