Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646843
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses |
| Date | 2017-05-22 14:50 +0200 |
| Message-ID | <tJUWC-5LA-3@gated-at.bofh.it> (permalink) |
| References | <tJTxw-50U-13@gated-at.bofh.it> <tJTxx-50U-25@gated-at.bofh.it> <tJTQS-56Q-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017-05-22 13:33, Joe Perches wrote:
> On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote:
>> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.
> []
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
> []
>> @@ -31,65 +31,78 @@
> []
>> +static const struct stmmac_pci_dmi_data iot2040_stmmac_dmi_data[] = {
>> {
>> - .name = "GalileoGen2",
>> .func = 6,
>> .phy_addr = 1,
>> },
>> {
>> - .name = "SIMATIC IOT2000",
>> - .asset_tag = "6ES7647-0AA00-0YA2",
>> - .func = 6,
>> + .func = 7,
>
> Why change this from 6 to 7?
>
The diff is confusing here: If you look at the outcome, we now have
galileo_stmmac_dmi_data with function 6 only (also used for the
IOT2020), and iot2040_stmmac_dmi_data with both function 6 and 7 (both
MACs are wired up).
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:20 +0200
Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Joe Perches <joe@perches.com> - 2017-05-22 13:40 +0200
Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 14:50 +0200
Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Joe Perches <joe@perches.com> - 2017-05-22 15:20 +0200
Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:10 +0200
csiph-web