Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645635

Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe
Date 2017-05-19 16:20 +0200
Message-ID <tIQV4-3mw-19@gated-at.bofh.it> (permalink)
References <tGa3T-7oh-9@gated-at.bofh.it> <tIEKd-35n-15@gated-at.bofh.it> <tIJJT-6HC-3@gated-at.bofh.it> <tIQV4-3mw-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote:
> +
> +	if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN)
> +		blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size);
> +	else
> +		blk_queue_logical_block_size(ns->queue, bs);

Ugg.  That will invalidate the layout of any existing fs (in case the
device hasn't eaten it yet).  It would also invalidate things like
partitions tables, even if they are only used to share with windows.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-12 06:10 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-12 16:00 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-12 16:10 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-12 16:40 +0200
        Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-13 02:00 +0200
          RE: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-15 18:00 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-13 14:30 +0200
    RE: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-15 18:20 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:20 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:20 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:40 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-19 03:40 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Christoph Hellwig <hch@infradead.org> - 2017-05-19 08:40 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive         than Intel RSTe Christoph Hellwig <hch@lst.de> - 2017-05-19 16:20 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Keith Busch <keith.busch@intel.com> - 2017-05-19 16:20 +0200
        Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 20:30 +0200
          Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Keith Busch <keith.busch@intel.com> - 2017-05-19 23:40 +0200

csiph-web