Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645071

Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

Show all headers | View raw

> I pondered this a bit, and I want to NAK my own patch.  This patch
> stinks -- there's mounting evidence that what it really does is to
> make any problems show up more rarely.  If a system is broken, I want
> it to be obviously broken.
>
> Here are two options to move forward:
>
> a) Leave the Dell quirk in place until someone from Dell or Samsung
> figures out what's actually going on.  Add a blanket quirk turning off
> the deepest sleep state on all Intel devices [1] at least until
> someone from Intel figures out what's going on -- Hi, Keith!  Deal
> with any other problems as they're reported.
>
> b) Turn off the deepest state across the board and add a whitelist.
> Populate the whitelist a bit.  The problem is that I don't even know
> what to whitelist.  My system works great, but does that mean that my
> particular laptop is fine?  My particular disk is certainly *not* fine
> when installed in other laptops.
> 
> Ideas?  (a) is a bit simpler to implement, I think, and may be good enough.
>
Until we have a proper solution for XPS 9550/Precision 5510 I agree that quirk should stay in place.
Of those two options I think A is better.  There are lots of machines this patch has helped that haven't been mentioned in this content.  Please make sure that it's not too aggressive on ITPT for PS4 if you're not aligning to RST behavior (should at "least" be 6s).

Kai-Heng and the Canonical team have also been looking at a lot of SSD/machine combinations with these various patches.  I hope they can speak up on what they've been finding.

> [1] There are problems on Intel NUC machines with Intel SSDs, for
> crying out loud.  I realize that the team that designs the NUC is
> probably totally unrelated to the SSD team, but they're both Intel and
> it shouldn't be *that* hard for someone at Intel to get it debugged.
> See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1686592

I would second this and love if Intel could speak up here on what direction they recommend to bring the NVME driver for APST.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-12 06:10 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-12 16:00 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-12 16:10 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-12 16:40 +0200
        Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-13 02:00 +0200
          RE: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-15 18:00 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-13 14:30 +0200
    RE: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-15 18:20 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:20 +0200
  Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:20 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 03:40 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe <Mario.Limonciello@dell.com> - 2017-05-19 03:40 +0200
    Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Christoph Hellwig <hch@infradead.org> - 2017-05-19 08:40 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive         than Intel RSTe Christoph Hellwig <hch@lst.de> - 2017-05-19 16:20 +0200
      Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Keith Busch <keith.busch@intel.com> - 2017-05-19 16:20 +0200
        Re: [PATCH] nvme: Change our APST table to be no more aggressive than  Intel RSTe Andy Lutomirski <luto@kernel.org> - 2017-05-19 20:30 +0200
          Re: [PATCH] nvme: Change our APST table to be no more aggressive  than Intel RSTe Keith Busch <keith.busch@intel.com> - 2017-05-19 23:40 +0200

csiph-web