Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641232

Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
Date 2017-05-15 02:30 +0200
Message-ID <tHc3D-x1-3@gated-at.bofh.it> (permalink)
References <tH5Ye-4E8-5@gated-at.bofh.it> <tH5Ye-4E8-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>

Hi Maciek

Please include some commit message, even if it is just the checkpatch
error you are fixing.

Please include the subsystem/driver you are patch in the subject line.
Also, your subject of Fix ERROR: makes it sound a lot worse than it
is. 

net: virtio: Fix checkpatch error Complex macros should use ()

Also, you should at least compile test your change. It is clearly
wrong, as shown by 0-day.

       Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Maciek Fijalkowski <macfij7@wp.pl> - 2017-05-14 20:00 +0200
  Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be  enclosed in parentheses Andrew Lunn <andrew@lunn.ch> - 2017-05-15 02:30 +0200
  Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be  enclosed in parentheses "Michael S. Tsirkin" <mst@redhat.com> - 2017-05-15 05:00 +0200

csiph-web