Re: [PATCH v2] perf report: distinguish between inliners in the same function

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] perf report: distinguish between inliners in the same function
Date	2017-05-15 02:50 +0200
Message-ID	<tHcmZ-Dg-1@gated-at.bofh.it> (permalink)
References	<tDaa6-2vi-17@gated-at.bofh.it> <tFsPg-5e7-11@gated-at.bofh.it> <tGg9k-36j-19@gated-at.bofh.it> <tGkcW-62A-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andi,

On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote:
> Milian Wolff <milian.wolff@kdab.com> writes:
> >
> > I think I'm missing something, but isn't this what this function provides? The 
> > function above is now being used by the match_chain_inliner function below. 
> >
> > Ah, or do you mean for code such as this:
> >
> > ~~~~~
> > inline_func_1(); inline_func_2();
> 
> This could be handled by looking at columns or discriminators too (which
> some compilers generate in dwarf). srcline.c would need to be changed
> to also call bfd_get_nearest_discriminator() and pass that extra
> information everywhere.

You're right.  The discriminators should be carried too.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff <milian.wolff@kdab.com> - 2017-05-12 12:40 +0200
  Re: [PATCH v2] perf report: distinguish between inliners in the same  function Namhyung Kim <namhyung@kernel.org> - 2017-05-12 15:10 +0200
    Re: [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff <milian.wolff@kdab.com> - 2017-05-14 20:20 +0200
      Re: [PATCH v2] perf report: distinguish between inliners in the same  function Namhyung Kim <namhyung@kernel.org> - 2017-05-15 03:30 +0200
        Re: [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff <milian.wolff@kdab.com> - 2017-05-15 12:10 +0200
          Re: [PATCH v2] perf report: distinguish between inliners in the same  function Namhyung Kim <namhyung@kernel.org> - 2017-05-16 03:00 +0200
            Re: [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff <milian.wolff@kdab.com> - 2017-05-16 15:20 +0200
              Re: [PATCH v2] perf report: distinguish between inliners in the same  function Namhyung Kim <namhyung@kernel.org> - 2017-05-17 08:20 +0200
                Re: [PATCH v2] perf report: distinguish between inliners in the same function Milian Wolff <milian.wolff@kdab.com> - 2017-05-18 14:30 +0200
  Re: [PATCH v2] perf report: distinguish between inliners in the same function Andi Kleen <andi@firstfloor.org> - 2017-05-12 17:00 +0200
    Re: [PATCH v2] perf report: distinguish between inliners in the same  function Namhyung Kim <namhyung@kernel.org> - 2017-05-15 02:50 +0200

csiph-web