Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1641169 > unrolled thread
| Started by | Maciek Fijalkowski <macfij7@wp.pl> |
|---|---|
| First post | 2017-05-14 20:00 +0200 |
| Last post | 2017-05-15 05:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Maciek Fijalkowski <macfij7@wp.pl> - 2017-05-14 20:00 +0200
Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Andrew Lunn <andrew@lunn.ch> - 2017-05-15 02:30 +0200
Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses "Michael S. Tsirkin" <mst@redhat.com> - 2017-05-15 05:00 +0200
| From | Maciek Fijalkowski <macfij7@wp.pl> |
|---|---|
| Date | 2017-05-14 20:00 +0200 |
| Subject | [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses |
| Message-ID | <tH5Ye-4E8-7@gated-at.bofh.it> |
From: Maciej Fijalkowski <macfij7@wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7@wp.pl>
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f20dfb8..6c8170c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
};
#define VIRTNET_FEATURES \
- VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
+ (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
VIRTIO_NET_F_MAC, \
VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \
@@ -2672,7 +2672,7 @@ static struct virtio_device_id id_table[] = {
VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, \
VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \
VIRTIO_NET_F_CTRL_MAC_ADDR, \
- VIRTIO_NET_F_MTU
+ VIRTIO_NET_F_MTU)
static unsigned int features[] = {
VIRTNET_FEATURES,
--
2.4.11
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-05-15 02:30 +0200 |
| Subject | Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses |
| Message-ID | <tHc3D-x1-3@gated-at.bofh.it> |
| In reply to | #1641169 |
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
Hi Maciek
Please include some commit message, even if it is just the checkpatch
error you are fixing.
Please include the subsystem/driver you are patch in the subject line.
Also, your subject of Fix ERROR: makes it sound a lot worse than it
is.
net: virtio: Fix checkpatch error Complex macros should use ()
Also, you should at least compile test your change. It is clearly
wrong, as shown by 0-day.
Andrew
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-05-15 05:00 +0200 |
| Subject | Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses |
| Message-ID | <tHeoN-1YZ-1@gated-at.bofh.it> |
| In reply to | #1641169 |
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7@wp.pl>
This is not a complex value.
> ---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index f20dfb8..6c8170c 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
> };
>
> #define VIRTNET_FEATURES \
> - VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
> + (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
> VIRTIO_NET_F_MAC, \
> VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
> VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \
> @@ -2672,7 +2672,7 @@ static struct virtio_device_id id_table[] = {
> VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, \
> VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \
> VIRTIO_NET_F_CTRL_MAC_ADDR, \
> - VIRTIO_NET_F_MTU
> + VIRTIO_NET_F_MTU)
>
> static unsigned int features[] = {
> VIRTNET_FEATURES,
> --
> 2.4.11
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web