Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637687

Re: [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations

Show all headers | View raw

----- Original Message -----
| From: Markus Elfring <elfring@users.sourceforge.net>
| Date: Sat, 6 May 2017 10:15:25 +0200
| 
| Some update suggestions were taken into account
| from static source code analysis.
| 
| Markus Elfring (10):
|   Replace six seq_puts() calls by seq_putc()
|   Add spaces for better code readability
|   Improve a size determination in table_seq_start()
|   Use kcalloc() in dlm_scan_waiters()
|   Improve a size determination in dlm_recover_waiters_pre()
|   Delete an error message for a failed memory allocation in
|   dlm_recover_waiters_pre()
|   Use kmalloc_array() in make_member_array()
|   Use kcalloc() in two functions
|   Improve a size determination in two functions
|   Delete an unnecessary variable initialisation in dlm_ls_start()
| 
|  fs/dlm/debug_fs.c | 25 ++++++++++++-------------
|  fs/dlm/lock.c     |  8 +++-----
|  fs/dlm/member.c   | 15 ++++++---------
|  3 files changed, 21 insertions(+), 27 deletions(-)
| 
| --
| 2.12.2
| 
| 
Hi Markus,

I'm not a DLM maintainer, but I've reviewed your patch set and ACK them.
They seem to fit the spirit of:

https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-memory

I've actually got a bunch of similar cleanups myself, but I don't think
there's any overlap.

Regards,

Bob Peterson
Red Hat File Systems

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] fs-DLM: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:40 +0200
  [PATCH 03/10] dlm: Improve a size determination in table_seq_start() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:40 +0200
  [PATCH 01/10] dlm: Replace six seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:40 +0200
  [PATCH 02/10] dlm: Add spaces for better code readability SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:40 +0200
  [PATCH 05/10] dlm: Improve a size determination in  dlm_recover_waiters_pre() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 04/10] dlm: Use kcalloc() in dlm_scan_waiters() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 09/10] dlm: Improve a size determination in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 08/10] dlm: Use kcalloc() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 06/10] dlm: Delete an error message for a failed memory  allocation in dlm_recover_waiters_pre() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 10/10] dlm: Delete an unnecessary variable initialisation in  dlm_ls_start() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 10:50 +0200
  Re: [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several  function implementations Bob Peterson <rpeterso@redhat.com> - 2017-05-08 22:10 +0200

csiph-web