Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding
Date	2017-05-08 22:10 +0200
Message-ID	<tEX8J-5q-5@gated-at.bofh.it> (permalink)
References	<tEQqB-434-1@gated-at.bofh.it> <tEQqB-434-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jim Baxter <jim_baxter@mentor.com>
Date: Mon, 8 May 2017 13:49:57 +0100

> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out->len) == 0.
> 
> I have resolved this by storing the size of
> the memory to be zeroed before the skb_put
> and using this in the memset call.
> 
> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
> Reviewed-by: Bjørn Mork <bjorn@mork.no>

Applied, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/1] net: cdc_ncm: Fix TX zero padding Jim Baxter <jim_baxter@mentor.com> - 2017-05-08 15:00 +0200
  [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding Jim Baxter <jim_baxter@mentor.com> - 2017-05-08 15:00 +0200
    Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding David Miller <davem@davemloft.net> - 2017-05-08 22:10 +0200

csiph-web