Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637686

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

Show all headers | View raw

On 05/08/2017 03:11 PM, Loc Ho wrote:
> Hi Jon,
> 
>>> The current SPCR code does not check the access width of the mmio, and
>>> uses a default of 8bit register accesses.  This prevents devices that
>>> only do 16 or 32bit register accesses from working.  By simply checking
>>> this field and setting the mmio string appropriately, this issue can be
>>> corrected.  To prevent any legacy issues, the code will default to 8bit
>>> accesses if the value is anything but 16 or 32.
>>
>> Thanks for this. Just as an FYI I've a running discussion with Microsoft
>> about defining additional UART subtypes in the DBG2 for special case
>> UARTs. Specifically, I want to address AppliedMicro's special 8250 dw IP
>> that also has a non-standard clock. At this time, there is general
>> agreement to use the access width for some cases rather than defining
>> yet more subtypes - so your patch is good.
>>
>> Loc/Applied: please track this thread, incorporate feedback, and also
>> track the other general recent discussions of 8250 dw from this week.
> 
> Thanks for forward me this patch. This patch does not work with X-Gene
> v1 and v2 SoC's. As BIOS SPCR encodes these info as:
> 
> Bit Width: 32
> Bit Offset: 0
> Encoded Access Width: 01 (Byte Access)
> 
> With this patch, it would use the "mmio" instead the "mmio32" as with
> this patch - https://patchwork.kernel.org/patch/9460959

I think this is why we need the DBG2 subtype for Applied X-Gene1. I'm
hoping the update to the SPCR/DBG2 spec is done soon.

Jon.

-- 
Computer Architect | Sent from my Fedora powered laptop

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Mason <jon.mason@broadcom.com> - 2017-05-04 17:10 +0200
  RE: [PATCH] ACPI: SPCR: Use access width to determine mmio usage "Moore, Robert" <robert.moore@intel.com> - 2017-05-04 18:30 +0200
    Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Mason <jon.mason@broadcom.com> - 2017-05-04 19:40 +0200
  RE: [PATCH] ACPI: SPCR: Use access width to determine mmio usage "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-05 05:10 +0200
    Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Mason <jon.mason@broadcom.com> - 2017-05-06 00:00 +0200
  Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Masters <jcm@redhat.com> - 2017-05-07 00:50 +0200
    Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Loc Ho <lho@apm.com> - 2017-05-08 21:20 +0200
      Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Loc Ho <lho@apm.com> - 2017-05-08 22:00 +0200
        Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Mason <jon.mason@broadcom.com> - 2017-05-08 22:40 +0200
          Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Loc Ho <lho@apm.com> - 2017-05-08 23:00 +0200
            Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Masters <jcm@redhat.com> - 2017-05-08 23:30 +0200
            Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Mason <jon.mason@broadcom.com> - 2017-05-08 23:30 +0200
              Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Loc Ho <lho@apm.com> - 2017-05-08 23:40 +0200
      Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage Jon Masters <jcm@redhat.com> - 2017-05-08 22:00 +0200

csiph-web