Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context
Date	2017-05-08 17:20 +0200
Message-ID	<tESC5-5Ad-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <tCBYJ-4BJ-3@gated-at.bofh.it> <tCFpD-6LL-3@gated-at.bofh.it> <tCFSG-7ab-9@gated-at.bofh.it> <tDrNE-60m-17@gated-at.bofh.it> <tDvHA-8tt-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 04, 2017 at 03:32:53PM -0500, Rob Herring wrote:
> On Thu, May 4, 2017 at 11:22 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > Am 02.05.2017 um 15:18 schrieb Johan Hovold:
> >> On Tue, May 02, 2017 at 07:41:34AM -0500, Rob Herring wrote:
> >>> On Tue, May 2, 2017 at 4:06 AM, Johan Hovold <johan@kernel.org> wrote:
> >>>> On Fri, Apr 28, 2017 at 01:47:21PM +0200, Stefan Wahren wrote:
> >>>>> Starting with commit 6fe729c4bdae ("serdev: Add serdev_device_write
> >>>>> subroutine") the function serdev_device_write_buf cannot be used in
> >>>>> atomic context anymore (mutex_lock is sleeping). So restore the old
> >>>>> behavior.
> >>>> Yeah, preventing use in atomic context seems unnecessary, although any
> >>>> clients writing must now deal with serialisation themselves (as before,
> >>>> and as they should).
> >>> We could just remove the mutex for serdev_device_write and always make
> >>> the client responsible for serialization.
> >> That sounds reasonable.
> >
> > So it's unwanted to have 2 write functions (non-atomic, atomic)?
> 
> No, it's unwanted to have more than we need.
> 
> Looking closer, we'd also have to ensure the wait for completion is
> not called also. So probably better to just leave it as you have done
> it.

Indeed. Sorry if my reply above was unclear on that point (i.e. that
Stefan's patch is still needed regardless of whether we keep the mutex
or not).

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serdev: Restore serdev_device_write_buf for atomic context Stefan Wahren <stefan.wahren@i2se.com> - 2017-04-28 13:50 +0200
  Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic  context Johan Hovold <johan@kernel.org> - 2017-05-02 11:10 +0200
    Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Rob Herring <robh@kernel.org> - 2017-05-02 14:50 +0200
      Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic  context Johan Hovold <johan@kernel.org> - 2017-05-02 15:20 +0200
        Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic  context Stefan Wahren <stefan.wahren@i2se.com> - 2017-05-04 18:30 +0200
          Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Rob Herring <robh@kernel.org> - 2017-05-04 22:40 +0200
            Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic  context Johan Hovold <johan@kernel.org> - 2017-05-08 17:20 +0200

csiph-web