Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634384
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context |
| Date | 2017-05-02 14:50 +0200 |
| Message-ID | <tCFpD-6LL-3@gated-at.bofh.it> (permalink) |
| References | <tBczo-6JZ-21@gated-at.bofh.it> <tCBYJ-4BJ-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 2, 2017 at 4:06 AM, Johan Hovold <johan@kernel.org> wrote:
> On Fri, Apr 28, 2017 at 01:47:21PM +0200, Stefan Wahren wrote:
>> Starting with commit 6fe729c4bdae ("serdev: Add serdev_device_write
>> subroutine") the function serdev_device_write_buf cannot be used in
>> atomic context anymore (mutex_lock is sleeping). So restore the old
>> behavior.
>
> Yeah, preventing use in atomic context seems unnecessary, although any
> clients writing must now deal with serialisation themselves (as before,
> and as they should).
We could just remove the mutex for serdev_device_write and always make
the client responsible for serialization.
> Calling wait_for_completion in the non-blocking case was also needlessly
> inefficient.
It won't be called because count should be 0.
Rob
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] serdev: Restore serdev_device_write_buf for atomic context Stefan Wahren <stefan.wahren@i2se.com> - 2017-04-28 13:50 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Johan Hovold <johan@kernel.org> - 2017-05-02 11:10 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Rob Herring <robh@kernel.org> - 2017-05-02 14:50 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Johan Hovold <johan@kernel.org> - 2017-05-02 15:20 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Stefan Wahren <stefan.wahren@i2se.com> - 2017-05-04 18:30 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Rob Herring <robh@kernel.org> - 2017-05-04 22:40 +0200
Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context Johan Hovold <johan@kernel.org> - 2017-05-08 17:20 +0200
csiph-web