Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1633162

Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments
Date 2017-04-28 23:10 +0200
Message-ID <tBljk-4Iv-23@gated-at.bofh.it> (permalink)
References <tBilr-2ly-1@gated-at.bofh.it> <tBiOt-2Nu-5@gated-at.bofh.it> <tBjKy-3t4-27@gated-at.bofh.it> <tBjUe-3ze-7@gated-at.bofh.it> <tBkdA-3Ib-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2017-04-28 at 12:51 -0700, Brian Norris wrote:
> FWIW, I don't see this consistently applied at all. Unless my regexes
> are completely wrong [*], it's roughly 50/50 in drivers/net/ and net/,
> and roughly 40/60 (favoring "net" style) in net/core/.

More like 5:1 in net/

$ git grep -E -n "/\*[ \t]*\w" net | grep -v ":1:" | wc -l
30461
$ git grep -E -n "/\*[ \t]*$" net | grep -v ":1:" | wc -l
6061

grep -v ":1:" is to avoid the first line in the file comment

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] checkpatch: don't encourage new code to use "networking" style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 20:00 +0200
  Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 20:30 +0200
    Re: [PATCH] checkpatch: don't encourage new code to use "networking"  style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 21:30 +0200
      Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments David Miller <davem@davemloft.net> - 2017-04-28 21:40 +0200
        Re: [PATCH] checkpatch: don't encourage new code to use "networking"  style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 22:00 +0200
          Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 23:10 +0200
      Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 21:40 +0200

csiph-web