Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633106

Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments
Date 2017-04-28 21:40 +0200
Message-ID <tBjUe-3ze-7@gated-at.bofh.it> (permalink)
References <tBilr-2ly-1@gated-at.bofh.it> <tBiOt-2Nu-5@gated-at.bofh.it> <tBjKy-3t4-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Brian Norris <briannorris@chromium.org>
Date: Fri, 28 Apr 2017 12:27:22 -0700

> On Fri, Apr 28, 2017 at 11:24:18AM -0700, Joe Perches wrote:
>> On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote:
>> I believe the only person that actually cares about
>> the networking
>> comment style is David Miller.
> 
> Which is why I've CC'd him. If even *he* doesn't care about having
> this warning in checkpatch, then why should anyone else?

Well it potentially saves one round trip for patch submissions.

What I'm not going to do is let people start using different comment
style even for new code in files like net/core/whatever.c after I've
spent nearly two decades getting them to be one way so far.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: don't encourage new code to use "networking" style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 20:00 +0200
  Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 20:30 +0200
    Re: [PATCH] checkpatch: don't encourage new code to use "networking"  style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 21:30 +0200
      Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments David Miller <davem@davemloft.net> - 2017-04-28 21:40 +0200
        Re: [PATCH] checkpatch: don't encourage new code to use "networking"  style comments Brian Norris <briannorris@chromium.org> - 2017-04-28 22:00 +0200
          Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 23:10 +0200
      Re: [PATCH] checkpatch: don't encourage new code to use  "networking" style comments Joe Perches <joe@perches.com> - 2017-04-28 21:40 +0200

csiph-web