Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633161

Re: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently

Show all headers | View raw

On Friday, April 28, 2017 01:30:20 PM Lv Zheng wrote:
> For all frequent late stage acpi_get_table() clone invocations, we should
> only fix them altogether, otherwise, excessive acpi_put_table() could
> unexpectedly unmap the table used by the other users. Thus the current plan
> is to fix all acpi_get_table() clones together or to fix none of them.

I honestly don't think that fixing none of them is a valid option here.

> This prevents kernel developers from improving the late stage code quality
> without waiting for the ACPICA upstream to improve first.
> 
> This patch adds a mechanism to stop decrementing validation count to
> prevent the table unmapping operations so that acpi_put_table() balance
> fixes can be done independently to each others.
> 
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> ---
>  drivers/acpi/acpica/tbutils.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c
> index 7abe665..b517bd0 100644
> --- a/drivers/acpi/acpica/tbutils.c
> +++ b/drivers/acpi/acpica/tbutils.c
> @@ -445,12 +445,18 @@ void acpi_tb_put_table(struct acpi_table_desc *table_desc)
>  
>  	ACPI_FUNCTION_TRACE(acpi_tb_put_table);
>  
> -	if (table_desc->validation_count == 0) {
> +	if ((table_desc->validation_count + 1) == 0) {

This means that validation_count has reached the maximum value, right?

>  		ACPI_WARNING((AE_INFO,
> -			      "Table %p, Validation count is zero before decrement\n",
> +			      "Table %p, Validation count is about to expire, decrement is unsafe\n",
>  			      table_desc));

So why is it unsafe to decrement it?

>  		return_VOID;
>  	}
> +	if (table_desc->validation_count == 0) {
> +		ACPI_ERROR((AE_INFO,
> +			   "Table %p, Validation count is zero before decrement\n",
> +			   table_desc));
> +		return_VOID;
> +	}
>  	table_desc->validation_count--;
>  
>  	if (table_desc->validation_count == 0) {
> 

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Lv Zheng <lv.zheng@intel.com> - 2017-04-27 10:30 +0200
  Re: [PATCH v2 1/2] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-28 00:40 +0200
    RE: [PATCH v2 1/2] ACPICA: Tables: Fix regression introduced by a  too early mechanism enabling "Zheng, Lv" <lv.zheng@intel.com> - 2017-04-28 03:30 +0200
    RE: [PATCH v2 1/2] ACPICA: Tables: Fix regression introduced by a  too early mechanism enabling "Zheng, Lv" <lv.zheng@intel.com> - 2017-04-28 06:00 +0200
  [PATCH v2 1/4] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Lv Zheng <lv.zheng@intel.com> - 2017-04-28 07:30 +0200
  [PATCH v3 1/4] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Lv Zheng <lv.zheng@intel.com> - 2017-04-28 07:40 +0200
  [PATCH v3 4/4] ACPI: Fix memory mapping leaks in current sysfs dumpable ACPI tables support Lv Zheng <lv.zheng@intel.com> - 2017-04-28 07:40 +0200
  [PATCH v3 3/4] ACPI: sysfs: Fix acpi_get_table() leak Lv Zheng <lv.zheng@intel.com> - 2017-04-28 07:40 +0200
  [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently Lv Zheng <lv.zheng@intel.com> - 2017-04-28 07:40 +0200
    Re: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-28 23:10 +0200
      RE: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to  balance late stage acpi_get_table() independently "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-04 09:20 +0200
        Re: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to balance  late stage acpi_get_table() independently Dan Williams <dan.j.williams@intel.com> - 2017-05-04 17:50 +0200
          RE: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to  balance late stage acpi_get_table() independently "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-05 03:00 +0200
        Re: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-05-05 22:50 +0200
          RE: [PATCH v3 2/4] ACPICA: Tables: Add mechanism to allow to  balance late stage acpi_get_table() independently "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-09 04:00 +0200
  [PATCH v4 3/4] ACPI: sysfs: Fix acpi_get_table() leak Lv Zheng <lv.zheng@intel.com> - 2017-05-09 08:00 +0200
  [PATCH v4 4/4] ACPI: Fix memory mapping leaks in current sysfs dumpable ACPI tables support Lv Zheng <lv.zheng@intel.com> - 2017-05-09 08:00 +0200
  [PATCH v4 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently Lv Zheng <lv.zheng@intel.com> - 2017-05-09 08:00 +0200
  [PATCH v4 1/4] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Lv Zheng <lv.zheng@intel.com> - 2017-05-09 08:00 +0200

csiph-web