[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Karim Eshapa <karim.eshapa@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.
Date	Wed, 26 Apr 2017 18:20:02 +0200
Message-ID	<tAxPA-4Ed-7@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=neL+OUktOsRf9t3F+z2aXIkdr3ZOzrUvH8BwEqUHcYk=; b=WwDvXZjD+MLQvalI5E3boy/jmTdPcu0iNkBXpP76ZDXhpy4Xtzk3CG2Twqr3H4XKRJ FHjDJ/cqL/EiyBSkYB3kXojnUafsD1RjZ67UXRqmBBhb/LGUlleoDXx7pjiEOpIP62hx Zgc3KdczGuN58Qvbn/oEh6C8NyZJBOIp9Xsw1wxKcae+2XoIlNzaX491Q5LjyzZKHsv3 VP1pryBG4OdgrkPj/iMlSZeqYDEL0Ote9H81X9W9izi2WyCcn4m4ac6UZfbxs6o7QhIf TCQzV1/jkjajzuI1R0K51JpZpqcvl3wnhzOD2gk+G1nSdQKWcvPURgagstzBNvTg38ui REbA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=neL+OUktOsRf9t3F+z2aXIkdr3ZOzrUvH8BwEqUHcYk=; b=k1OUvioQG3u6czxWEhYZozkTm/jIRNfQhuxQbcraAYcnwHxNgqeUgR0JHDb7ZjykXW tMHeNQtoy/GXSXpE4XxX65V6qpBDsoVWgEDW0A3/38mBESeDL8xj1+loUbTXXYgECRIB ZYbntvylUtt+em2JlKtdtHCv6d4sxAA0AdYBWs3DBPhFM2+Zg3MiuGSIPRzh/QS1Wxom pI/9R5g/ZQsXRNBZvDWZknnM1l1yBaSJl70xjm9YnrnmgEvj/XtoWuChqOq+KaQE8qrJ FIIPaU6JLnOHtaTLWzD+St7oPN72Qgg7VfDabmPV3XE0YyFjLLVPOZco7XI9fl6ytLuS 1pog==
X-Gm-Message-State	AN3rC/5dElrsMVkFvhVYbDes1aJg7bSfEPSm6MagKi5a6iVvJt1g29GT UVpmebGvLv4qsA==
X-Received	by 10.223.139.92 with SMTP id v28mr386097wra.177.1493223353072; Wed, 26 Apr 2017 09:15:53 -0700 (PDT)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Karim Eshapa <karim.eshapa@gmail.com>
X-Original-Date	Wed, 26 Apr 2017 18:15:40 +0200
X-Original-Message-ID	<1493223340-13794-1-git-send-email-karim.eshapa@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1631594

Show key headers only | View raw

Fixing sparse warnings incorrect type assignment.

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba..cf6bf65 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 		datap = skb_put(skb, sizeof(struct p80211_caphdr));
 		caphdr = (struct p80211_caphdr *)datap;
 
-		caphdr->version = htonl(P80211CAPTURE_VERSION);
-		caphdr->length = htonl(sizeof(struct p80211_caphdr));
+		caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+		caphdr->length = __be32_to_cpu( htonl(sizeof(
+						struct p80211_caphdr)));
 		caphdr->mactime = __cpu_to_be64(rxdesc->time) * 1000;
 		caphdr->hosttime = __cpu_to_be64(jiffies);
-		caphdr->phytype = htonl(4);	/* dss_dot11_b */
-		caphdr->channel = htonl(hw->sniff_channel);
-		caphdr->datarate = htonl(rxdesc->rate);
-		caphdr->antenna = htonl(0);	/* unknown */
-		caphdr->priority = htonl(0);	/* unknown */
-		caphdr->ssi_type = htonl(3);	/* rssi_raw */
+
+		/* dss_dot11_b */
+		caphdr->phytype = __be32_to_cpu(htonl(4));
+
+		caphdr->channel = __be32_to_cpu(htonl(hw->sniff_channel));
+		caphdr->datarate = __be32_to_cpu(htonl(rxdesc->rate));
+		caphdr->antenna =  __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->priority = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->ssi_type = __be32_to_cpu(htonl(3));	/* rssi_raw */
 		caphdr->ssi_signal = htonl(rxdesc->signal);
 		caphdr->ssi_noise = htonl(rxdesc->silence);
-		caphdr->preamble = htonl(0);	/* unknown */
-		caphdr->encoding = htonl(1);	/* cck */
+		caphdr->preamble = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->encoding = __be32_to_cpu(htonl(1));	/* cck */
 	}
 
 	/* Copy the 802.11 header to the skb
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-26 18:20 +0200
  Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse  warnings. Greg KH <gregkh@linuxfoundation.org> - 2017-04-28 12:10 +0200
  RE:[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-30 18:30 +0200
    Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Arnd Bergmann <arnd@arndb.de> - 2017-05-08 00:20 +0200
  RE: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-10 15:20 +0200

csiph-web