Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631594

[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.

From Karim Eshapa <karim.eshapa@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.
Date 2017-04-26 18:20 +0200
Message-ID <tAxPA-4Ed-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Fixing sparse warnings incorrect type assignment.

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba..cf6bf65 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 		datap = skb_put(skb, sizeof(struct p80211_caphdr));
 		caphdr = (struct p80211_caphdr *)datap;
 
-		caphdr->version = htonl(P80211CAPTURE_VERSION);
-		caphdr->length = htonl(sizeof(struct p80211_caphdr));
+		caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+		caphdr->length = __be32_to_cpu( htonl(sizeof(
+						struct p80211_caphdr)));
 		caphdr->mactime = __cpu_to_be64(rxdesc->time) * 1000;
 		caphdr->hosttime = __cpu_to_be64(jiffies);
-		caphdr->phytype = htonl(4);	/* dss_dot11_b */
-		caphdr->channel = htonl(hw->sniff_channel);
-		caphdr->datarate = htonl(rxdesc->rate);
-		caphdr->antenna = htonl(0);	/* unknown */
-		caphdr->priority = htonl(0);	/* unknown */
-		caphdr->ssi_type = htonl(3);	/* rssi_raw */
+
+		/* dss_dot11_b */
+		caphdr->phytype = __be32_to_cpu(htonl(4));
+
+		caphdr->channel = __be32_to_cpu(htonl(hw->sniff_channel));
+		caphdr->datarate = __be32_to_cpu(htonl(rxdesc->rate));
+		caphdr->antenna =  __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->priority = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->ssi_type = __be32_to_cpu(htonl(3));	/* rssi_raw */
 		caphdr->ssi_signal = htonl(rxdesc->signal);
 		caphdr->ssi_noise = htonl(rxdesc->silence);
-		caphdr->preamble = htonl(0);	/* unknown */
-		caphdr->encoding = htonl(1);	/* cck */
+		caphdr->preamble = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->encoding = __be32_to_cpu(htonl(1));	/* cck */
 	}
 
 	/* Copy the 802.11 header to the skb
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-26 18:20 +0200
  Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse  warnings. Greg KH <gregkh@linuxfoundation.org> - 2017-04-28 12:10 +0200
  RE:[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-30 18:30 +0200
    Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Arnd Bergmann <arnd@arndb.de> - 2017-05-08 00:20 +0200
  RE: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-10 15:20 +0200

csiph-web