Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632763
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. |
| Date | 2017-04-28 12:10 +0200 |
| Message-ID | <tBb0B-5UI-9@gated-at.bofh.it> (permalink) |
| References | <tAxPA-4Ed-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 26, 2017 at 06:15:40PM +0200, Karim Eshapa wrote: > Fixing sparse warnings incorrect type assignment. > > Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com> > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 6134eba..cf6bf65 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, > datap = skb_put(skb, sizeof(struct p80211_caphdr)); > caphdr = (struct p80211_caphdr *)datap; > > - caphdr->version = htonl(P80211CAPTURE_VERSION); > - caphdr->length = htonl(sizeof(struct p80211_caphdr)); > + caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION)); > + caphdr->length = __be32_to_cpu( htonl(sizeof( > + struct p80211_caphdr))); How do you know this is correct? And why the odd ' ' usage? I can't take this patch for that reason alone... thanks, greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-26 18:20 +0200
Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Greg KH <gregkh@linuxfoundation.org> - 2017-04-28 12:10 +0200
RE:[PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-30 18:30 +0200
Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Arnd Bergmann <arnd@arndb.de> - 2017-05-08 00:20 +0200
RE: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings. Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-10 15:20 +0200
csiph-web