Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type
Date	2017-04-27 17:10 +0200
Message-ID	<tATdn-2kj-3@gated-at.bofh.it> (permalink)
References	<ty4yl-7Xj-5@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote:

> When building object-list.o, gcc 6 raises a warning on the sprintf call
> in fscache_objlist_show:
> 
>   CC      fs/fscache/object-list.o
> fs/fscache/object-list.c: In function ‘fscache_objlist_show’:
> fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a
> terminating nul past the end of the destination [-Wformat-overflow=]
>     sprintf(_type, "%02u", cookie->def->type);
>                    ^~~~~~
> fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4
> bytes into a destination of size 3
>     sprintf(_type, "%02u", cookie->def->type);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Moreover, the documentation says that we should have an hex value for
> special cookies (see Documentation/filesystems/caching/fscache.txt).
> 
> Printing hexadecimal value for special cookies fixes the overflow
> warning and complies with the documentation.

Fine by me.  We don't actually handle special type cookies at the moment, so
you're not going to see anything other than DT or IX for now anyway.

I'll push this in the next merge window if that's okay with you.

David

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells <dhowells@redhat.com> - 2017-04-27 17:10 +0200
  Re: [PATCH] FS-Cache: print hexadecimal value for special cookies  type Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-04-27 17:20 +0200
    Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells <dhowells@redhat.com> - 2017-04-27 17:50 +0200

csiph-web